Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: api maintenance message is a FeatureHasBeenSunsetError when env.MODE is READ_ONLY #2346

Merged
merged 7 commits into from
Jan 9, 2024

Conversation

gobengo
Copy link
Contributor

@gobengo gobengo commented Jan 8, 2024

Motivation:

  • make sure the maintenance message is more helpful once we use the READ_ONLY mode to sunset writes

@gobengo gobengo requested a review from a team as a code owner January 8, 2024 19:09
@gobengo gobengo changed the title api maintenance message is a FeatureHasBeenSunsetError when env.MODE is READ_ONLY feat: api maintenance message is a FeatureHasBeenSunsetError when env.MODE is READ_ONLY Jan 8, 2024
@@ -46,7 +46,7 @@
]
},
"engines": {
"node": "16.x",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: the 'api' package CI already uses node 18 to test and doesn't test on 16 anyway

Copy link
Contributor

github-actions bot commented Jan 8, 2024

@alanshaw alanshaw merged commit 8c29cec into main Jan 9, 2024
22 checks passed
@alanshaw alanshaw deleted the maintenance-message-1704736978 branch January 9, 2024 14:27
alanshaw pushed a commit that referenced this pull request Jan 9, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.39.0](website-v2.38.2...website-v2.39.0)
(2024-01-09)


### Features

* api maintenance message is a FeatureHasBeenSunsetError when env.MODE
is READ_ONLY
([#2346](#2346))
([8c29cec](8c29cec))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
alanshaw pushed a commit that referenced this pull request Jan 9, 2024
🤖 I have created a release *beep* *boop*
---


##
[7.23.0](api-v7.22.0...api-v7.23.0)
(2024-01-09)


### Features

* api maintenance message is a FeatureHasBeenSunsetError when env.MODE
is READ_ONLY
([#2346](#2346))
([8c29cec](8c29cec))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants